search

kpi-web-guild / django-girls-blog-RootenberG

django-girls-blog-RootenberG created by GitHub Classroom
MIT License
0 stars 0 forks source link

Create Blog app with a post model #24

Closed RootenberG closed 5 years ago

webknjaz commented 5 years ago

"and" in the PR and commit message suggests that there's two separate changes meaning that they should go to separate atomic commits.

webknjaz commented 5 years ago

Add migrations module

it's a package, not a module. + the first commit message still refers to multiple things

RootenberG commented 5 years ago

Add migrations module

it's a package, not a module. + the first commit message still refers to multiple things

Вo you mean a model creating?

webknjaz commented 5 years ago

I mean the commit message.

RootenberG commented 5 years ago

I mean the commit message.

What changes should I share?

webknjaz commented 5 years ago

You shouldn't say that you exclude a module because you exclude a collection of modules which is a package.

RootenberG commented 5 years ago

You shouldn't say that you exclude a module because you exclude a collection of modules which is a package.

I fixed it.