search

kpi-web-guild / django-girls-blog-l1storez

django-girls-blog-l1storez created by GitHub Classroom
MIT License
0 stars 0 forks source link

Deploy to Heroku #30

Closed l1storez closed 3 years ago

l1storez commented 3 years ago

I need some help with this PR

l1storez commented 3 years ago

Split commit ddaef4c into several atomic?

webknjaz commented 3 years ago

Why is 0253acb9d766b3ff1e9a3f5dde8efd9d21ff6c9c separate?

webknjaz commented 3 years ago

Split commit ddaef4c into several atomic?

I'd fix the commit message to be useful at least. But maybe. It's currently unclear what it's supposed to do from the message having a list of things that don't represent any specific changes.

webknjaz commented 3 years ago

Also, what's with the PR description?

l1storez commented 3 years ago

Why is 0253acb separate?

In GHA happened dependency incompatibility

webknjaz commented 3 years ago

Why is 0253acb separate?

In GHA happened dependency incompatibility

So what?

l1storez commented 3 years ago

So what?

I did not rebase it because I was waiting for an answer to the question about the first commit. As there are options or squash with the first commit or make a new commit(for example "add dependencies for Heroku) and squash with it

l1storez commented 3 years ago

It looks like you've failed to follow this step: http://whitenoise.evans.io/en/stable/django.html#enable-whitenoise

This step is not in the tutorial. But if it is necessary, I will add

webknjaz commented 3 years ago

This step is not in the tutorial. But if it is necessary, I will add

The tutorial does not use the version of Whitenoise that you integrated. This is why we agreed earlier that if you want to use a different version, you should follow the documentation that describes how to integrate it properly. Also, if you want to check if your integration actually works, just run the command from the web section in Procfile locally.

l1storez commented 3 years ago

Also, if you want to check if your integration actually works, just run the command from the web section in Procfile locally.

Okay, thanks

l1storez commented 3 years ago

This step is not in the tutorial. But if it is necessary, I will add

Done!

webknjaz commented 3 years ago

Please make the commit messages useful and atomic. Changing and adding files without a specified purpose is weird.

webknjaz commented 3 years ago

This PR describes the steps

It doesn't describe anything at all

l1storez commented 3 years ago

It doesn't describe anything at all

Okay:)

l1storez commented 3 years ago

Oh, wow