search

kpi-web-guild / django-girls-blog-schenkh

django-girls-blog-schenkh created by GitHub Classroom
MIT License
0 stars 0 forks source link

Add Travis CI integration #16

Closed schenkh closed 5 years ago

schenkh commented 5 years ago

Resolves #9

webknjaz commented 5 years ago

Add .travis.yml

It's an obvious implementation detail. You should describe the high-level effect of this commit. Like "Configure Travis CI" or "Add initial Travis CI config file"

webknjaz commented 5 years ago

Add integration with Travis CI in feature/travis-ci-integration

This PR description is stating too many implementation details. The branch name is visible in the UI and in general, is not useful for the reader. Also, since it doesn't add value to the PR title you may as well just drop it and only keep Resolves ... line there.

webknjaz commented 5 years ago

Oh, you'll need to wait for pre-commit config to be checked in first. (See the log)

webknjaz commented 5 years ago

@schenkh don't merge PRs having red CI.

schenkh commented 5 years ago

Ok, I thought it fails because this branch is not merged.

webknjaz commented 5 years ago

No guesses, go to https://github.com/kpi-web-guild/django-girls-blog-schenkh/pull/16/checks and open builds to see what's happening there. Also, this branch was out-of-date. Rebasing it would've updated CI statuses with more relevant info.