kpi-web-guild / django-girls-blog-serhii73

django-girls-blog-serhii73 created by GitHub Classroom
MIT License
0 stars 1 forks source link

Include app URL to the project #24

Closed serhii73 closed 6 years ago

serhii73 commented 6 years ago

@webknjaz All good? Can we merge this branch to master?

webknjaz commented 6 years ago

Rebase it and get rid of unrelated commits.

serhii73 commented 6 years ago

@webknjaz Done.

serhii73 commented 6 years ago

@webknjaz Can we to merge the PR?

webknjaz commented 6 years ago

pylint will fail.

serhii73 commented 6 years ago

@webknjaz Maybe close this PR and to merge just https://github.com/kpi-web-guild/django-girls-blog-serhii73/pull/25 ?

serhii73 commented 6 years ago

@webknjaz But I can't merge the PR in master, because Travis is red. blog/urls.py:L 7:(no-member) Module 'blog.views' has no 'post_list' member (C 19), ::E1101 I think I need to unite https://github.com/kpi-web-guild/django-girls-blog-serhii73/pull/24 with https://github.com/kpi-web-guild/django-girls-blog-serhii73/pull/25 . For example, if I here I need to run git merge feature/6/django_views or to do the opposite?

webknjaz commented 6 years ago

That's the whole point to having Travis.

webknjaz commented 6 years ago

The approval means that I agree with what I see in PR, it doesn't mean that it is safe to merge. And review is about high-level things, which are not checked by robots.

serhii73 commented 6 years ago

@webknjaz What do you recommend to do?

webknjaz commented 6 years ago

Merge #25

webknjaz commented 6 years ago

(to master!)

serhii73 commented 6 years ago

@webknjaz done