Closed serhii73 closed 6 years ago
Rebase it and get rid of unrelated commits.
@webknjaz Done.
@webknjaz Can we to merge the PR?
pylint will fail.
@webknjaz Maybe close this PR and to merge just https://github.com/kpi-web-guild/django-girls-blog-serhii73/pull/25 ?
@webknjaz But I can't merge the PR in master, because Travis is red.
blog/urls.py:L 7:(no-member) Module 'blog.views' has no 'post_list' member (C 19), ::E1101
I think I need to unite https://github.com/kpi-web-guild/django-girls-blog-serhii73/pull/24 with https://github.com/kpi-web-guild/django-girls-blog-serhii73/pull/25 .
For example, if I here I need to run git merge feature/6/django_views
or to do the opposite?
That's the whole point to having Travis.
The approval means that I agree with what I see in PR, it doesn't mean that it is safe to merge. And review is about high-level things, which are not checked by robots.
@webknjaz What do you recommend to do?
Merge #25
(to master!)
@webknjaz done
@webknjaz All good? Can we merge this branch to master?