search

kpi-web-guild / django-girls-blog-serhii73

django-girls-blog-serhii73 created by GitHub Classroom
MIT License
0 stars 1 forks source link

Apply styles to our page #29

Closed serhii73 closed 6 years ago

serhii73 commented 6 years ago

@webknjaz The PR ready to merge.

serhii73 commented 6 years ago

@webknjaz There is no limit to perfection. But I think my commit is not bad, because of it short and fully explains what has been done. I think the answer to the question "why" there is no need, because and so it is clear why we need styles. I am happy to learn, what would you change. Thank you very much.

webknjaz commented 6 years ago

How does "our page" point to anything useful or recognizable?

serhii73 commented 6 years ago

@webknjaz I'm guilty, agree.

Merge pull request #29 from kpi-web-guild/feature/6/css

    Apply styles to our page

and then my commit Apply styles to page I think better when commit == the name of the theme. I just had a commit to copy and paste the name of the theme. But commit Apply styles to page is good?

webknjaz commented 6 years ago

To unspecified page?

serhii73 commented 6 years ago

@webknjaz Ok, Apply styles, right?

webknjaz commented 6 years ago

Which styles? Where?

serhii73 commented 6 years ago

Apply styles to post_list, ok?

webknjaz commented 6 years ago

It's http request handler, which has nothing to do with styles