Closed slsh1o closed 4 years ago
@serhii73 let me know if it's ok that I add you to all my PRs. If it's to much I won't add you as frequently as I did it :D
All good :+1:
Excuse me @webknjaz Why Travis? Why not GitHub actions?
@serhii73 there's a lot of options, we cannot try all of them at once. Maybe later.
@dark-lord671 changed the username
Plz exclude commits that belong to the
features/pre-commit-integration
branch by rebasing on top of master.
If I will fix commits messages from #17 and than merge features/pre-commit-integration
w/ master branch will it enough?
Commit message improvements:
Add Travis CI badge
where to?
I thought it's obvious where changes happens. Or if there are several commits in a row it would be better to add also explicit description in which file I add something?
My text sounds a little rude but I really just want to know how to do it better😅
Also:
-Add Travic CI config file +Add Travis CI config file
Can't find where this happened😅
If I will fix commits messages from #17 and than merge
features/pre-commit-integration
w/ master branch will it enough?
You should reply after the quotes not before, preserving the natural order of messages.
In the case of merging #17, I'll still demand a rebase here.
Can't find where this happened
I thought it's obvious where changes happens. Or if there are several commits in a row it would be better to add also explicit description in which file I add something?
I'm not sure which quote this refers to but whenever you make a commit, it should be atomic and the reader should understand what it's about w/o looking into other places. You should maintain a good Git history for other humans and your future self, otherwise, it's hard to track the decisions and thought flows that lead to making them back to the past.
Imagine you see a piece of git log
that looks like this:
* fix
|
* Add Travis CI badge
|
* Fix Travis CI badge
|
* Add Travis CI badge
Can you say, w/o checking the contents of each commit, that the Travis CI badge was added to docs and to the README? What was fixed? Where?
You should reply after the quotes not before, preserving the natural order of messages.
Oh sorry, edited my message.
Can you say, w/o checking the contents of each commit, that the Travis CI badge was added to docs and to the README? What was fixed? Where?
Now I got what you mean. Thx.
P.S. It shouldn't necessarily be a full file name but it's good if it's a distinguishable pointer to some concrete place.
Rebase this branch on top of master and make message of 4d9ca724 more clear.
Could as well fix this:
Add Travic CI config file
All seems to be ok. Except:
Here I just copy-pasted your code. Looks like it is what I actually should do but if something else let me know please.
@serhii73 let me know if it's ok that I add you to all my PRs. If it's to much I won't add you as frequently as I did it :D
Also traditionally ask for review @dark-lord671 and @ZVitaliy
Close #15