search

kplindegaard / smbus2

A drop-in replacement for smbus-cffi/smbus-python in pure Python
MIT License
243 stars 68 forks source link

Added support for FreeBSD #81

Open 0xc0decafe opened 2 years ago

0xc0decafe commented 2 years ago

As developed and designed for use on RBPi, all read and write ops are implemented using the I2CRDWR syscall, it beeing the only one implemented in the bcm2835_bsc driver.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kplindegaard commented 2 years ago

Hi @0xc0decafe and thanks for your PR :)

Unfortuantely I don't have time to review it right now, but I will come back with comments later. Doing some minor maintenance on the CI setup and stuff first. The plan is to get 0.4.2 out so that everything is as up to date as possible first.

brd commented 1 year ago

@kplindegaard ping? :)

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

0xc0decafe commented 11 months ago

Hi @kplindegaard, thanks for your suggestions. How about you put the generic changes into the code base, the design then can be to your pleasing. After that I'll come back and add the FreeBSD specific implementation. After all I'm doing this in my free time to the best of the community, and I really don't want a lengthy back and forth over design decisions. Best