kpmck / cypress-ag-grid

Cypress plugin for interacting with ag grid

30 stars 17 forks source link

Added support for filter menu's without tabs #4

Closed air2 closed 3 years ago

air2 commented 3 years ago

The ag-grid community edition does have tabs in the filter menu.

Therefore an option noMenuTabs is added to get it working with this version of ag-grid.

Fixes issue #3

kpmck commented 3 years ago

Thanks so much for opening a pull request! I made a couple of comments on the code; one typo appears to be failing the tests, and there are items removed that I do not believe should be removed. I will work on getting an example of an AG Grid into the repository so we can run tests on those instances as well as the enterprise edition.

air2 commented 3 years ago

Thank you for looking at it so quickly. And thank u for the comments.