kpmg-agile / ca-pqvp

KPMG submission for CA PQVP
https://www.calproc.website
7 stars 3 forks source link

accessibility: html_codesniffer complains about hash routes #196

Closed robertlevy closed 7 years ago

robertlevy commented 7 years ago

we are using angular2's hashlocationstrategy for routing.

the accessibility testing cool complains about href's pointing to non-existant anchors. this is possibly classifiable as a false-positive because those anchors will be created via javascript when the user tried to navigate to them. but, it's worth looking at what it would take to swith to pathlocationstrategy

https://angular.io/docs/ts/latest/api/common/index/PathLocationStrategy-class.html