search

kpmg-agile / ca-pqvp

KPMG submission for CA PQVP
https://www.calproc.website
7 stars 3 forks source link

accessiility tweaks #268

Closed robertlevy closed 7 years ago

robertlevy commented 7 years ago

1) product detail page quantity input field needs a label

i modified to html to include 

                        <label for="quantity" data-i18n="quantity"></label>
                        <input id="quantity" type="number" min="0" [(ngModel)]="quantity" class="quantity-input"/>

but it wonked up the layout so leaving this for casey.

2) should not be using <h5> without being under h1...h4. use h1 or another tag here

3) cart page has same issue with quantity needing a label

4) compare has a similar issue but its complaining we have h2 without h1

robertlevy commented 7 years ago

please make this change on the cleanup branch i have going

robertlevy commented 7 years ago

please add the quanitity label on the Cart page too