Parameter `absolute` in bool SenMLRecord::setTime(double value, bool absolute) is incorrect

kpn-iot / thingsml-c-library

C library for ThingsML on your device

https://kpn-iot.github.io/thingsml-c-library/

MIT License

6 stars 4 forks source link

Parameter `absolute` in bool SenMLRecord::setTime(double value, bool absolute) is incorrect #25

Open JulianvDoorn opened 2 years ago

JulianvDoorn commented 2 years ago

On the following line: https://github.com/kpn-iot/thingsml-c-library/blob/91b51bb55c9d38f9ad0af3a9a03ca9a1f29cc7bf/src/senml/record/senml_record.cpp#L25

A bool absolute is defined as parameter. But the behavior in the implementation when absolute == true, is that the times in the records become relative. I think the parameter name is incorrectly specified.