kpopnet / kpopnet.json

K-pop open data
Creative Commons Zero v1.0 Universal
5 stars 0 forks source link

feat: active group field/occupation status #6

Open castdrian opened 8 months ago

castdrian commented 8 months ago

firstly lovely project, very thankful for the fact that it is typed as well, ideally it would be nice to have two additional fields on the idol spec:

activeGroup the idols current group if it exists

occupation: perhaps an enum that differentiates between SOLOIST and GROUP

Kagami commented 8 months ago

Hi!

activeGroup the idols current group if it exists

Idol might be in two different groups, e.g. Nana from woo!ah! and EL7Z U+P (the second is temporary though). Also subunits count as groups too and in many groups disband_date isn't properly set so it still counts as current idol's group.

You can filter out all groups with current=false, e.g. . as $r | .idols[] | select(.name=="Sakura") as $i | $r.groups[] | select(.members[] | select(.idol_id==$i.id and .current)) | {idol: $i, group: .} click

Maybe we should add temporary: boolean; field for the groups and fix the disband dates so that you can always filter out all non-primary groups of the idol (you can also check if it's not subunit by parent_id==null)? What do you think?

occupation: differentiates between SOLOIST and GROUP

Oh yeah, I was thinking about how to differentiate non-active idols and idols performing as soloists. Maybe we can have fake group with name something like SOLO and add all soloists there?

Not sure what to do with e.g. Twice or Blackpink idols because a lot of them have released albums as a solo artists but can we actually count them as soloists?

castdrian commented 8 months ago

I think a placeholder group that says solo is a great idea, personally I would say idols who are still part of a group aren't soloists even if they have released solo music, but since it's your project it's up to you really

Kagami commented 8 months ago

idols who are still part of a group aren't soloists

I agree.