search

kpreisser / winforms

Windows Forms is a .NET Core UI framework for building Windows desktop applications.
MIT License
0 stars 0 forks source link

Simplify setting dialog icon from bitmaps #15

Closed RussKie closed 4 years ago

RussKie commented 4 years ago

Typically images are used from Resources, and those are of Bitmap type. The existing API only takes Icon that requires additional work from a developer, which wouldn't be straight forward for a significant part of the development community, e.g.:

new TaskDialogIcon(Icon.FromHandle(Properties.Resources.Network.GetHicon()))

Provide an overload that takes a Bitmpa and handles the necessary plumbing.

RussKie commented 4 years ago

Updated

kpreisser commented 4 years ago

Thanks a lot!

RussKie commented 4 years ago

Looks like we'll need to implement IDisposable on TaskDialogPage et al after all :) TIL that to make the TaskDialog design-able we'll need to implement IComponent to show in the designer. This is obviously not something we'll need to action immediately, just sharing the learning.