kprinssu / anne-keyboard-windows

A Universal Windows Platform App for controlling Anne Pro Bluetooth enabled keyboards.
MIT License
139 stars 10 forks source link

Crash when deleting profile #26

Closed SuperCuber closed 6 years ago

SuperCuber commented 6 years ago

Steps to reproduce:

1) Create a new profile 2) Move to "lights" screen 3) Try to delete said profile 4) App should crash after a couple seconds of freezing, any changes to profiles not saved

ethanmsmith commented 6 years ago

Alright, so think I know why this is happening, could you tell me what profile is being deleted in order in the dropdown? e.g. are you deleting the first or last profile in the list, or something in between?

SuperCuber commented 6 years ago

I tested it when I had 2 profiles and tried deleting the 2nd one

kprinssu commented 6 years ago

Which version of the app are you using?

SuperCuber commented 6 years ago

Using version 1.0.4

ethanmsmith commented 6 years ago

I think I found the problem. I've taken profile logic out of individual pages. (Really should have done that when I refactored the pages, but I didn't want to.) @kprinssu What is the build process? Ill build my fork and have @SuperCuber and possibly others confirm its fixed.

SuperCuber commented 6 years ago

@ethanmsmith sure thing, make sure to ping me on that fork though

ethanmsmith commented 6 years ago

Perfect. Once it's ready, will do

kprinssu commented 6 years ago

@ethanmsmith can you please create a PR? I will run a new build on my Windows VM after some testing.

ethanmsmith commented 6 years ago

So, I did fix the profile crashing, but since I can never do one thing at a time, I changed a decent chunk of the current code to native XAML controls. I need to fix a few minor bugs I introduced...

kprinssu commented 6 years ago

Okay. Tag me in the new PR and I’ll do the rest.

ethanmsmith commented 6 years ago

Newest build should fix this issue @SuperCuber

SuperCuber commented 6 years ago

@ethanmsmith Tested, looks like the issue is fixed. Closing.