search

kprinssu / anne-keyboard-windows

A Universal Windows Platform App for controlling Anne Pro Bluetooth enabled keyboards.
MIT License
139 stars 10 forks source link

Profile selection / renaming #6

Closed Kitinni closed 8 years ago

Kitinni commented 8 years ago

Currently it's not very clear how to select a Profile, clicking the name on the left will focus on a textbox to edit so only the area around the textbox can be clicked to select the profile.

anneprofile

I thought of 2 possible improvements here, the easiest would be to have the Profile list on the left be labels and change the 'Selected Profile Label' to be a textbox for editing instead (Either click to edit, or add an edit icon so it's clear http://fontawesome.io/icon/pencil/ )

Another way of handling it would be to have clicking in the list once select the profile and double-click to edit the name, but this would involve hiding the textbox to replace it with a label and showing it when the text is double-clicked. It might also be less self-explanatory that way

Do you have any thoughts on this before I work on a PR?

kprinssu commented 8 years ago

Sounds a like good idea. XAML has a SymbolIcon element, and all of the icons in the app are using it. The UWP framework has default icons you can use, here's a good list that you can take a look at: https://msdn.microsoft.com/library/windows/apps/dn252842

kprinssu commented 8 years ago

Added this feature in https://github.com/kprinssu/anne-keyboard-windows/commit/838de9141a0d6799ecc37d06cfda88b9ac748425

Let me know if you spot any bugs.

Kitinni commented 8 years ago

Awesome, that's what I was going for but I had issues with the IDs being the same when relying solely on the count. Good solution with the KeyboardProfiles_CollectionChanged function.

I had a play around creating and deleting some profiles and it no longer deletes the wrong profiles when creating and deleting multiple with the same label :+1: