Double check `find_package` works

kprussing / FindLatexmk

Cmake module to add latexmk support

1 stars 0 forks source link

Double check `find_package` works #3

Open kprussing opened 3 years ago

kprussing commented 3 years ago

Quick checks using find_package weren't working for me. I tried setting CMAKE_MODULE_PATH as an environment variable or as a cache variable (both in the CMakeLists.txt and on the command line). Nothing seemed to locate the module. This could be a user error, but I was trying to finish up the details for #2.

kprussing commented 3 years ago

And when texlive is installed as a module (i.e. not in the default location), it didn't properly search the PATH to locate the executable. The -DLatexmk_Executable flag had to be added.

kprussing commented 3 years ago

A few more notes:

It looks like the find_package_handle_standard_args should use the REQUIRED_VAR in order to fail early, but that needs more reading of the documentation (or not. if it's there, I seem to get a false negative. More debugging is required)
For some reason, when using modules, it's triggering Latexmk_DIR implying the if (DEFINED Latexmk_DIR) near line 150 is not doing what I think it does.