search

kpsuperplane / homebridge-wiz-lan

Control Wiz lights over LAN
Apache License 2.0
115 stars 37 forks source link

Still Reports as On When Unplugged #11

Closed mitch7391 closed 3 years ago

mitch7391 commented 4 years ago

@kpsuperplane I noticed something after testing out a Filament style bulb that I didn’t turn off but instead just unscrewed it from the lamp. In HomeKit it was still reporting as ‘on’ until I pressed off in the Home app; this makes me suspect that feedback status or polling is not properly implemented. Have you noticed these issues before?

MoTechnicalities commented 4 years ago

This is confirmed. The offline bulbs fail to report a "No Response" status in HomeKit. They continue to show the most recent state prior to disconnect.

mitch7391 commented 4 years ago

@MoTechnicalities is there any plan to fix this functionality? Or is it intentional? It makes more sense for it to report correctly that it has ‘no response’ if the device is unreachable.

muzzymate commented 4 years ago

I like the idea of reporting "No response" if the device is offline to communicate to the user that the bulb is uncontrollable and can not be turned on.

mitch7391 commented 4 years ago

@dotkrnl or @kpsuperplane do you think this is possible for a future update?

kpsuperplane commented 4 years ago

Unfortunately I no longer have any wiz bulbs, but happy to accept any PRs if someone wants to do the work

mwwgithub commented 4 years ago

Unfortunately I no longer have any wiz bulbs, but happy to accept any PRs if someone wants to do the work

What a shame. I just started using your plugin and other than this bug, it has further increased the value proposition of the Philips branded WiZ bulbs available at Home Depot.

If I ship you a bulb would you consider continued improvements to your plugin?

tbelcher commented 3 years ago

Unfortunately I no longer have any wiz bulbs, but happy to accept any PRs if someone wants to do the work

@kpsuperplane would you be able to walk me through the plugin and how it works? I'd be willing to mess around with it, but don't have a strong background in Homebridge plugins.

mitch7391 commented 3 years ago

These now report as 'No Response' like they should when powered off at the switch thanks to #32; closing out!