kpsuperplane / homebridge-wiz-lan

Control Wiz lights over LAN
Apache License 2.0
117 stars 37 forks source link

Adding light pole support #133

Closed jeppesens closed 1 year ago

kpsuperplane commented 1 year ago

As someone who isn't familiar with the pole, what's the reasoning for separating it out from WizBulb? :O

jeppesens commented 1 year ago

As someone who isn't familiar with the pole, what's the reasoning for separating it out from WizBulb? :O

TBH none whatsoever, reading your code it felt like it would make more sense to separate them.

Also I believe that it would be sufficient to have RGB here

kpsuperplane commented 1 year ago

If you don't mind, I'd prefer to keep to fold Light Poles into WizBulb then since they share the same capabilities.

jeppesens commented 1 year ago

It is now a part of the same class I also changed name from Bulb to Light, hope you don't mind