kpsuperplane / homebridge-wiz-lan

Control Wiz lights over LAN
Apache License 2.0
115 stars 37 forks source link

Remove obsolete/invalid parameters from setPilot to fix #6 #7

Closed dotkrnl closed 4 years ago

dotkrnl commented 4 years ago

A recent upgrade to the A19 bulbs breaks this plugin. Some bulbs no longer respond to Homekit control via this plugin. (#6)

My investigation found that the new upgrade made changes to the requirements of the parameters. If the parameters "sceneId":0,"c":0,"w":0 are sent to the bulb, it returns 'Invalid params' and fails.

By removing these parameters, this plugin works again on A19.

Reviews are required before merging this PR. I don't have other models of the bulb so I do not know if it will break old firmware. Please provide feedback!

wilkinsm89 commented 4 years ago

Fixed the issue I was facing. Thanks 👍

MoTechnicalities commented 4 years ago

I'm ready for any update offered for Hoobs! I have a lot of these WIZ bulbs that worked in Homekit with Hoobs before the WIZ App update. Out with the old! In with the new! Thanks.

trandaniel24 commented 4 years ago

Not working for me sadly :(. Anything else I can try? I'm using A.E27 and CA.E14, which worked before.

kariuki86 commented 4 years ago

I have several A19s and this was the exact fix. Nice work, and thank you!