search

kptdev / kpt

Automate Kubernetes Configuration Editing
https://kpt.dev
Apache License 2.0
1.71k stars 227 forks source link

Propagate ResourceGroup labels and annotations #4165

Closed fsommar closed 4 months ago

fsommar commented 4 months ago

When I declare a ResourceGroup on disk, I expect the labels and annotations defined on it to be propagated to the in-cluster inventory. That was previously not the case.

kioutil annotations are removed (path, index, etc) since they are redundant for inventories that are typically defined in one place, and don't need to be reconstructed by a function pipeline.

fsommar commented 4 months ago

Failure is unrelated, due to busybox image being too old. I can change it to the docker hub one, but I assume that you prefer to have it in GCR/GAR?

fsommar commented 4 months ago

Thanks for the review @mortent! I don't have permissions to merge, can you do it for me? 🙇