Failures when integrating in gecko-dev

kpu / intgemm

int8_t and int16_t matrix multiply based on https://arxiv.org/abs/1705.01991

Other

63 stars 21 forks source link

Failures when integrating in gecko-dev #97

Closed andrenatal closed 2 years ago

andrenatal commented 2 years ago

Incompatibility issues were found when integrating this into gecko-dev which is putting it at risk of being backed-out. More info on: https://bugzilla.mozilla.org/show_bug.cgi?id=1754207#c3

kpu commented 2 years ago

As I understand it, this is an alert that there are more static constructors in the compiled executable. Let's follow this on bugzilla.

andrenatal commented 2 years ago

Sure, but if any fixes to the codebase are required, the ideal would be to happen here on upstream, because there's a script on gecko-dev that pulls a specific commit from here and then updates there.

kpu commented 2 years ago

Requested changes now in master.

kpu commented 2 years ago

Bugzilla shows as resolved. Reminder that the number of static constructors has not changed (and therefore the compiler metric remains unchanged) but they are short.