search

kpumuk / codecolorer

WordPress plugin which allows you to insert code snippets into the post with nice syntax highlighting.
https://kpumuk.info/projects/wordpress-plugins/codecolorer/
56 stars 14 forks source link

line number column width, RTL websites... #17

Closed Abu3safeer closed 6 years ago

Abu3safeer commented 6 years ago

Hello, thank you for this amazing plugin, but I noticed an issue with 'number column' width, I thought this issue appeared on my website, but it happened on your website also. image as you can see the column takes too much width, I fixed that on my website with css but it is better to have it fixed from the source.

I have website that uses RTL direction, but that affected code snippets also, but codes must be LTR. This is how it will be look like image I also fixed that with css, but it is better to be solved from the source.

Thank you again.

kpumuk commented 6 years ago

Hi! Thank you for your feedback.

Could you submit a pull request, or post the changes you have made to fix these issues here?

kpumuk commented 6 years ago

Does this look close? https://github.com/kpumuk/codecolorer/pull/18

Abu3safeer commented 6 years ago

Yes, this should fix the issue, can't wait to test it on the next update.

kpumuk commented 6 years ago

Already available at https://wordpress.org/plugins/codecolorer/

Abu3safeer commented 6 years ago

Thank you, working properly.

kpumuk commented 6 years ago

👍

Abu3safeer commented 6 years ago

could you make it fixed? I thought closing it would make it fixed, sorry for that.

kpumuk commented 6 years ago

:-) I don't think there is a way to do that. Let's just leave it "closed"