kpumuk / meta-tags

Search Engine Optimization (SEO) for Ruby on Rails applications.
MIT License
2.73k stars 275 forks source link

Fixed double escaping of special characters in title #105

Closed kgorin closed 8 years ago

kgorin commented 8 years ago

This is related to and supersedes https://github.com/kpumuk/meta-tags/pull/85

kgorin commented 8 years ago

@kpumuk can you review this PR?

Lewis-Clayton commented 8 years ago

+1

kgorin commented 8 years ago

@kpumuk hey, have you had a chance to review this PR?

miharekar commented 8 years ago

I fixed it by just

def self.strip_tags(string)
  helpers.sanitize(string)
end

Now better way would be to rename strip_tags everywhere to sanitize. But yeah, please merge some variation that will fix this bug.

kgorin commented 8 years ago

@kpumuk hey, any chance this is getting merged?

kpumuk commented 8 years ago

Resolved in https://github.com/kpumuk/meta-tags/pull/120