kpumuk / meta-tags

Search Engine Optimization (SEO) for Ruby on Rails applications.
MIT License
2.73k stars 275 forks source link

Use Module#prepend instead of alias_method_chain #109

Closed plguo closed 8 years ago

plguo commented 8 years ago

As alias_method_chain is being deprecated in Rails 5, it replaced alias_method_chain with Module#prepend from Ruby 2+. In addition to #93, this pull request use prepend instead of include to ensure the MetaTags::ControllerHelper#render called before calling ActionController::Base#render.

The test is broken since the render is no longer blocked by render_without_meta_tags.

alpaca-tc commented 8 years ago

👍 Thanks! hmm.. how can i create rspec fixes PR to this one?

https://github.com/kpumuk/meta-tags/commit/8cfc0f86549d

plguo commented 8 years ago

Not familiar how it works

siegy22 commented 8 years ago

I decided to fork this project onto my account as the owner is no longer really active. I implemented this change in https://github.com/Elektron1c97/meta_tags-rails/commit/8e873c70c3e2ab718f5d58ec986954969f00a5d9

You can use my gem for the future 👍

teohm commented 8 years ago

@Elektron1c97 do you plan to actively maintain the project?

siegy22 commented 8 years ago

@teohm Yes I'm thinking about that because the maintainer here was not active for over a half year..

luizpicolo commented 8 years ago

Thanks Brow

kpumuk commented 8 years ago

The issue has been resolved in https://github.com/kpumuk/meta-tags/commit/f0f83641ba2eba5dc6eeb5610d8e6cb1d7a5e785