Double escaping - Githubissues

kpumuk / meta-tags

Search Engine Optimization (SEO) for Ruby on Rails applications.

MIT License

2.73k stars 275 forks source link

Double escaping #110

Closed svoop closed 8 years ago

svoop commented 8 years ago

Due to a bug in strip_tags (introduced with Rails 4.2), ampersands and quotes are escaped twice. The "to_s.gsub" can be removed once the affected Rails versions are not widely used anymore, see: https://github.com/rails/rails-html-sanitizer/issues/28

One test failed due to this Rails bug, with this PR, all tests are green again.

vinnie-eb commented 8 years ago

Any chance this is going to be merged soon?

kpumuk commented 8 years ago

Fixed in https://github.com/kpumuk/meta-tags/pull/120