search

kpumuk / meta-tags

Search Engine Optimization (SEO) for Ruby on Rails applications.
MIT License
2.73k stars 275 forks source link

Rails 5: alias_method_chain is deprecated #115

Closed jeroenvisser101 closed 8 years ago

jeroenvisser101 commented 8 years ago

When meta-tags is being used on Rails 5.0.0.beta3, there's a deprecation warning:

DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from alias_method_chain at /usr/local/opt/rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/activesupport-5.0.0.beta3/lib/active_support/core_ext/module/aliasing.rb:27)

Which is being called from lib/meta_tags/controller_helper.rb:16

jeroenvisser101 commented 8 years ago

@kpumuk would you accept PRs created to fix this? I'd be happy to give it a shot

zealot128 commented 8 years ago

There is already a PR open #109

bragovo commented 8 years ago

Rails 5 released by warning still exists.

siegy22 commented 8 years ago

I decided to fork this project onto my account as the owner is no longer really active. I implemented this change in Elektron1c97@8e873c7

You can use my gem for the future 👍

jeroenvisser101 commented 8 years ago

@Elektron1c97 thanks, that's great! Please don't forget to add docs for the new things you add, so when @kpumuk will be active again it could easily be merged back :)

siegy22 commented 8 years ago

Sure 👍 @jeroenvisser101

simoniong commented 8 years ago

Thanks for the great work @Elektron1c97

kpumuk commented 8 years ago

The issue has been addressed in https://github.com/kpumuk/meta-tags/commit/f0f83641ba2eba5dc6eeb5610d8e6cb1d7a5e785