simple modification to accept any named meta tag.

kpumuk / meta-tags

Search Engine Optimization (SEO) for Ruby on Rails applications.

MIT License

2.73k stars 275 forks source link

simple modification to accept any named meta tag. #28

Closed pedrofs closed 11 years ago

pedrofs commented 12 years ago

I think it should be great and it is a very simple modification, something like 3 lines of code.

pedrofs commented 12 years ago

please, forget it. this commit made some tests to break up.

pedrofs commented 12 years ago

i fixed the broke tests and added one to test my feature.

esthervillars commented 11 years ago

+1 for this one

MatthewCallis commented 11 years ago

Is there any reason this hasn't been pulled in? I need this feature and would rather not fork the gem.

kpumuk commented 11 years ago

This change will break "Twitter Cards" feature (see README), and arbitrary hashes support ("Hashes" section in README). Instead of filtering by list of "known" parameters, what about we delete items from a copy of meta tags Hash once they are processed, and then just render the rest?

kpumuk commented 11 years ago

Implemented in #32