HTML attribute strings should be escaped

kpumuk / meta-tags

Search Engine Optimization (SEO) for Ruby on Rails applications.

MIT License

2.73k stars 275 forks source link

Closed davidstosik closed 9 years ago

davidstosik commented 10 years ago

The following code:

set_meta_tags og: {description: 'Testing "double quotes".'}

Will output HTML below:

<meta content="Testing "double quotes"." property="og:description" />

Double quotes are not escaped, breaking the HTML markup.

kpumuk commented 9 years ago

Fixed in 1c4ed2157e4a869dc57ed521fbe562522c872ecf and 60483ec6c60346546780ac58bbb5f98443ca11ee