strip_tags is breaking special characters. i would use sanitize instead

kpumuk / meta-tags

Search Engine Optimization (SEO) for Ruby on Rails applications.

MIT License

2.73k stars 275 forks source link

strip_tags is breaking special characters. i would use sanitize instead #85

Closed willybaer closed 8 years ago

willybaer commented 9 years ago

strip_tags is breaking my special characters, i am using instead sanitize.
Have a look on the following problem https://github.com/rails/rails-html-sanitizer/issues/31

momelnyk commented 9 years ago

+1 for merge

alexkravets commented 9 years ago

+1 for merge, right now we have to link to the branch instead

kle-roy commented 9 years ago

+1 for merge, using willybaer's branch too

irubnich commented 8 years ago

+1 for merge

kgorin commented 8 years ago

@kpumuk Can we get this updated and merged? I could provide tests for this as well. /cc @willybaer

kpumuk commented 8 years ago

The main idea was to remove HTML tags, which strip_tags does. I understand the problem with special chars, but the PR as it is now breaks the initial goal, allowing certain HTML tags to pass through. If you would update it to make sure no HTML tags pass through, and add specs - I don't see any reasons why it could not be merged.

kpumuk commented 8 years ago

And it breaks current specs suite :-)

kpumuk commented 8 years ago

We pass encode_special_chars: false to Loofah when doing strip_tags now.