search

kputnam / stupidedi

Ruby API for parsing and generating ASC X12 EDI transactions
BSD 3-Clause "New" or "Revised" License
265 stars 137 forks source link

Use consistent naming for "Code List Qualifier Code" #247

Closed milieu closed 2 years ago

milieu commented 2 years ago

Noticed that in lib/stupidedi/transaction_sets/005010/implementations/X279A1-HB271.rb while everywhere else in the file for this code it said "Code List Qualifier Code", in the Dependents section it'd say "Code List Qualifier"... and that bugged me out a lot. Ended up trying to make the entire repo consistent.

~/l/stupidedi ❯❯❯ ag '"Code List Qualifier"' | wc -l
      40
~/l/stupidedi ❯❯❯ ag '"Code List Qualifier Code"' | wc -l
     266

Command ran:

ag -l '"Code List Qualifier"' | xargs -n 1 gsed -ri 's/"Code List Qualifier"/"Code List Qualifier Code"/'

kputnam commented 2 years ago

Haha, there's a decent chance I spaced out when transcribing all those PDFs, but I wouldn't be surprised to see the specification PDFs had the same inconsistencies. Thanks Meredeth!