search

kputnam / stupidedi

Ruby API for parsing and generating ASC X12 EDI transactions
BSD 3-Clause "New" or "Revised" License
262 stars 137 forks source link

Feature/po103/add more uom options #251

Closed SCMths closed 1 year ago

SCMths commented 1 year ago

This PR aims to introduce more Unit of Measurement options for E355 version 004010

SCMths commented 1 year ago

Hey @kputnam, while merging this into my fork I accidently created the PR in your repository, please disregard.

I'd be happy to collaborate and reopen if you see fit.

I am sorry about it.

kputnam commented 1 year ago

No problem @SCMths. I don't have access to the official 4010 X12 specification, so I cannot verify if your changes are compatible with that spec. If you have access to this documentation and can verify compatibility, I will merge these changes.

It's not uncommon for trading partners to color outside the lines of the X12 standard, and merging this change would affect all users of the library. This is why I have been cautious about merging changes to definitions. But if you can verify these changes against one of the X12 org's PDFs I will merge it.

SCMths commented 1 year ago

Thank you for understanding @kputnam, I will let you know if I can validate it.