kputnam / stupidedi

Ruby API for parsing and generating ASC X12 EDI transactions
BSD 3-Clause "New" or "Revised" License
265 stars 137 forks source link

add 270 support for U gender #261

Closed JakeDMSnap closed 1 year ago

jrohrbaugh commented 1 year ago

@kputnam could you please take a look at this PR? Much appreciated!

kputnam commented 1 year ago

Since I no longer have the X12 spec, I can't check if this conforms to the spec.

I found stedi's documentation includes X279A1, which defines the 270 and 271 transaction sets, but it doesn't show element-level detail. I'm including this link because they have good reference documentation in general and it might be useful to others.

One of CMS's (Medicare) implementation guides does say U can be used for unknown. It would be unusual for Medicare to allow values which aren't allowed by the standard. Medicare is also often regarded as an authority in terms of what X12 should be accepted by commercial payers, so I'm going to say this is good enough evidence to suggest it's probably allowed by the standard.

If anyone does have the X279A1 guide, please let me know if U is not allowed in the implementation section and I will back this change out -- in that case users would need to create payer-specific transaction set grammars by copying the standard and making modifications.

I'll merge this and push a new version tonight. cc: @jrohrbaugh

jrohrbaugh commented 1 year ago

confirmed that change fixed our problem. Thanks for the quick and detailed response! When I was researching I also found that CMS guide you shared, but I wasn't sure how official it was. I'll see if anyone at my company has access to an official spec.