Closed todd-cook closed 3 years ago
Thank you! I have a few comments on the PR, but I wanted to say that I appreciate the submission.
Thanks for your feedback and patience!
Thank you for the contribution and working with me to resolve all the corner cases. It's very much appreciated!
Kevin, for further PRs, this is the right repo and fork approach that you prefer? https://thespianpy.com/doc/#outline-container-orgd95dc23 Contributions section points to this/your repo. But the pypi and travis stats seem to be out of: https://github.com/thespianpy/Thespian and the PRs there are old. I like the history of the project and preserving things. Just didn't want to be annoying you with PRs to your fork if there's a more direct way.
Either repo is fine, and I monitor both and keep them generally in sync.
The original was published by my previous employer for whom I did most of the initial development. After I left, I maintained my fork actively whereas they did no further updates. After a number of years, they transferred the original to me under the thespianpy group, but I didn't want to break any links or other references to my kquick version that folks might be maintaining, so I've just kept both in parallel.
Thanks for checking in though: I should clarify this situation in the README and ensure the documentation and CI is updated.
re: https://github.com/kquick/Thespian/issues/70
I extracted the method and created a doctest using the example config (from https://github.com/kquick/Thespian/blob/master/examples/logsetup.py#L10).
Tested with Docker and Kubernetes