kr-colab / diploSHIC

feature-based deep learning for the identification of selective sweeps
MIT License
49 stars 14 forks source link

`DataFrame` has no attribute `as_matrix()` #24

Closed nspope closed 2 years ago

nspope commented 4 years ago

Hi,

With python 3.69, pandas 1.0.1: the member function DataFrame.as_matrix() isn't available (I think it has been deprecated for awhile). This causes predict mode to fail. The issue is fixed by changing x_df.as_matrix() to x_df.values, in:

https://github.com/kern-lab/diploSHIC/blob/7d55417af438e321c374dadc2f7e58f56107443e/diploSHIC.py#L278-L281

I don't think this change will cause issues with older versions of pandas, as DataFrame.values has been around for a long time ...

Nate

andrewkern commented 2 years ago

hey @nspope! i'm gonna close this stale issue