flake8 linting - Githubissues

kr-colab / diploSHIC

feature-based deep learning for the identification of selective sweeps

MIT License

49 stars 14 forks source link

flake8 linting #5

Closed molpopgen closed 5 years ago

molpopgen commented 5 years ago

I want to start working on performance of processing ms records, and also fix some errors in ms position to integer conversion. I got side tracked by too many flake8 errors in the buffers. Thus, this PR does the following:

[x] remove all use of from foo import *. from the SHIC version of making feature vectors from ms data.
[x] address all flake8 issues in that file + msTools.py
[x] address all flake8 issues in fvTools.py

molpopgen commented 5 years ago

@andrewkern -- flake8 finds several instances of undefined variables in fvTools.py, so this PR has become more than a code formatting exercise. The linter has found some real bugs. I have flagged some of them with "AK" in the comments.

molpopgen commented 5 years ago

@andrewkern the files changed in this PR have had enough flake8 fixes that using a code linter in vim will show the real bugs and not be cluttered with pep8 formatting issues. I use syntastic for running the linter after every :w.

andrewkern commented 5 years ago

thanks Kevin these are really helpful