Closed cjbattey closed 6 months ago
yo @cjbattey! thanks for doing this. I'll definitely look through it in the next day or so. seems like a lot of code moved here-- mostly auto-reformatting?
Thanks! Yes, almost all black reformat and build stuff. popvae.py also moved to the top level directory to work with the new build system. But there were no changes in popvae.py code other than import commands to work with a newer Keras version.
@andrewkern oops, sorry about that. Fixed now, and I added a --test
function. Please pull and give it another shot with python popvae.py --test
(shouldn't need to reinstall).
This PR updates python, all dependency versions, the build system, and installation instructions to address https://github.com/kr-colab/popvae/issues/22. This setup worked for a fresh install on an M3 MacBook, using mamba for the virtual environment. There are no changes to analytical code.
Sorry about the size of the PR -- it's mostly build stuff and
black
reformatting the code. The relevant changes for installation are switchingsetup.py
topyproject.toml
, README updates, and some minor refactors ofplotvae.py
to work with a newer version ofbokeh
.Changes:
python setup.py install
topip install ./
for package installationI tried to get this working with smaller tweaks I think five separate times and kept getting sucked in to more and more confusing dependency issues. But python 3.7 and tensorflow 1 are old enough to be dropping off pip, so have to update. I think (hope) this one will work.
@andrewkern , any chance you or someone in the lab could give this a shot and see if they can install and run the test data?