kr / binarydist

Go implementation of bsdiff & bspatch
http://godoc.org/github.com/kr/binarydist
MIT License
306 stars 40 forks source link

Is there a reason to not use Go's qsufsort implementation? #3

Closed c4milo closed 8 years ago

c4milo commented 8 years ago

https://golang.org/src/index/suffixarray/qsufsort.go

kr commented 8 years ago

Oh, nice. Thanks for the pointer!

Had I known about index/suffixarray when I wrote this, I probably would have used it. Instead, I just translated the original bsdiff and bspatch C code nearly line for line. Now it seems to work fine as-is, so really the question is, is there a reason to switch to index/suffixarray? I don't see anything compelling.