Fix updates on Windows - Githubissues

kr / hk

Fast Heroku client

https://hk.heroku.com/

77 stars 6 forks source link

Closed inconshreveable closed 10 years ago

inconshreveable commented 10 years ago

Fixes issue #62

Failed Windows updates were caused by trying to rename the old executable while there was still an open file handle on it.

bgentry commented 10 years ago

:shit:, I completely glossed over the fact that we were reading the existing binary at any point (I was focused on the install() function).

@inconshreveable can you just rebase this branch on our master? After that, I'll merge it in.

bgentry commented 10 years ago

Actually I took care of this, merged as 1aec653a9c184ecbf8a5e91d2afc292622401419. Thanks!