search

kr / hk

Fast Heroku client
https://hk.heroku.com/
77 stars 6 forks source link

Fix issue destroying app #84

Closed tt closed 10 years ago

tt commented 10 years ago

This fixes an issue where you cannot destroy an app because the add-on check tries to resolve the app name based on the "heroku" remote.

kr commented 10 years ago

Looks good to me. Thanks!

bgentry commented 10 years ago

@kr we require you to remove all addons from the app before destroying it, but there's no hk command to destroy an addon (or all addons)? yuck :(

kr commented 10 years ago

Yeah, we should fix that, one way or the other. :)

bgentry commented 10 years ago

@kr even if I had those commands, I'd want to be able to "just fucking destroy it" with a -f or something. I don't want to run 2 commands when a single API call does what I want.

bgentry commented 10 years ago

Thanks!

kr commented 10 years ago

I'm fine with taking out the check for addons. Same goes for scaling to zero.

bgentry commented 10 years ago

@kr I'm also ok with removing the checks now that you are required to pass in the app name as part of the command, and it's never inferred from .git/config