search

kr / hk

Fast Heroku client
https://hk.heroku.com/
77 stars 6 forks source link

404 when creating an app #85

Closed bgentry closed 11 years ago

bgentry commented 11 years ago 
$ ./hk create
Unexpected error: 404 Not Found

$ hk create omgwtfapp
Unexpected error: 404 Not Found
kr commented 11 years ago

Are we trying to use v2 api paths in the v3 api?

bgentry commented 11 years ago

@kr nah, it's more subtle. Due to a change in API v3 identifiers. We were passing this in for create:

{"name":"omgwtfapp","region":{}}

Because serializing with omitempty apparently doesn't cover empty sub-structs.

About to push a fix up, but I wouldn't be surprised if there were more bugs uncovered because of this change in the API. I will do an audit for omitempty to see if I can catch more.

bgentry commented 11 years ago

Actually it looks like there aren't any more cases of this bug. :v: