search

kr / hk

Fast Heroku client
https://hk.heroku.com/
77 stars 6 forks source link

Use godep #93

Closed bgentry closed 11 years ago

bgentry commented 11 years ago

This one has no vendoring, unlike the existing godep branch. Is that an unreleased feature of godep? You think we should vendor our deps here too?

Fixes #92.

kr commented 11 years ago

You have to run godep save -copy to get vendoring. I need to improve the documentation.

Personally I think we should vendor our deps here. The underlying mechanism there is so much simpler. And we'll never have to worry about github availability or network speed during a deploy.

kr commented 11 years ago

A potential gotcha, the full command to run here would be

$ godep save -copy ./...

because we have more than one package in the repo! Sorry if my previous comment was misleading.

bgentry commented 11 years ago

Merged.