search

kr / pretty

Pretty printing for Go values
http://godoc.org/github.com/kr/pretty
MIT License
1.36k stars 155 forks source link

Fix MIT license for pkg.go.dev; tidy go.mod and create go.sum #62

Closed myitcv closed 4 years ago

myitcv commented 4 years ago

Currently the documentation for github.com/kr/pretty is not displayed on pkg.go.dev because of license restrictions:

https://pkg.go.dev/github.com/kr/pretty?tab=doc

This is almost certainly because the License file includes an errant header:

The MIT License (MIT)

The actual MIT license does not include this header:

https://opensource.org/licenses/MIT

GitHub and other interfaces surface the type of the license through automatic detection (as will pkg.go.dev). Hence this header is superfluous in any case.

Whilst we are at it, tidy up go.mod and add go.sum.

kr commented 4 years ago

Sweet, thanks!

myitcv commented 4 years ago

Thanks. You're going to need to cut a new version for pkg.go.dev to see the changes

dmitshur commented 4 years ago

This is almost certainly because the License file includes an errant header:

The MIT License (MIT)

As a data point, this LICENSE file gets recognized as the MIT license (see https://pkg.go.dev/github.com/shurcooL/httpfs?tab=licenses), but its header is a shorter "MIT License" text from https://choosealicense.com/licenses/mit/.