kr / webx

Crazy experimental HTTP-over-RSPDY router
12 stars 1 forks source link

logging features #6

Open kr opened 11 years ago

kr commented 11 years ago

On top of just having logs in the first place (#5), possibly useful:

@rhyselsmore:

Unsure if this is the correct area, but further down the list I think that logging needs to be discussed.

I have had several customers asking about filtering query strings within logs. Can we put this in the 'nice-to-haves'?

@neilmiddleton:

IMO this is up to the application. For instance, Rails has a log redactor that redacts secrets from the log entries (password, and password_confirmation out of the box)

@rhyselsmore:

Apparently it still doesn't stop the router from displaying it.

@neilmiddleton:

Ah yeah, sure. I was only thinking about the logs that Rails emits. Fair issue.