kr8gz / PlayerStatistics

Adds a command to your Fabric server that gives players insights into everyone's statistics.
https://modrinth.com/mod/playerstatistics
MIT License
3 stars 1 forks source link

1.21 #1

Closed i240c closed 2 months ago

i240c commented 2 months ago

Hello, is there a 1.21 update planned for this mod?

kr8gz commented 2 months ago

Hello, thank you for your interest in my mod! I definitely intend to continue developing and maintaining this mod. I am pretty busy right now though, so unfortunately it won't happen anytime soon :(

MJRamon commented 2 months ago

Would be also great to have 1.20.1 version, as many modpacks and servers are still running it and will do for a long time. Thanks!

kr8gz commented 2 months ago

Hello @MJRamon, please check out the newest release! About an update for 1.21: Since Minecraft 1.20.5 was already a large update, this will take a lot longer – please be patient :)

MJRamon commented 2 months ago

Hello @MJRamon, please check out the newest release!

That's great, appreciate!

kr8gz commented 2 months ago

@MJRamon sorry for the disappointment lol, silly me didn't think of testing compatibility both ways before releasing – I am now figuring out a new strategy to support different versions within the same project. The code itself doesn't require any further changes, but sadly dependencies rely heavily on the Minecraft version :/

(I wanted to get at least something done before I won't be able to work on it for at least a month, unfortunately I don't think that's gonna happen though 😭)

MJRamon commented 2 months ago

@kr8gz Damn, I was excited to implement it into project that heavily relies on player statistics (deadline is several weeks), as this mod is absolutely great for what I need. Maybe there's a way to release a specific 1.20.1 version? That would help a lot.

kr8gz commented 2 months ago

@MJRamon I'm curious, what kind of project? Also yeah I can try to make a one-off thing tomorrow 🙂

kr8gz commented 2 months ago

Hello @MJRamon, please try this release!

MJRamon commented 2 months ago

Hello @MJRamon, please try this release!

Thank you very much, will do tests. As for project - it's a private server built around advancements, stats, with tracking and leaderboard

MJRamon commented 2 months ago

Hello @MJRamon, please try this release!

When starting a fresh server without any stats, mod fails:

[13:52:54] [DefaultDispatcher-worker-1/ERROR]: Uncaught exception in thread "DefaultDispatcher-worker-1"
java.nio.file.NoSuchFileException: .\world\stats
        at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:85) ~[?:?]
        at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103) ~[?:?]
        at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:108) ~[?:?]
        at sun.nio.fs.WindowsDirectoryStream.<init>(WindowsDirectoryStream.java:86) ~[?:?]
        at sun.nio.fs.WindowsFileSystemProvider.newDirectoryStream(WindowsFileSystemProvider.java:535) ~[?:?]
        at java.nio.file.Files.newDirectoryStream(Files.java:482) ~[?:?]
        at java.nio.file.Files.list(Files.java:3792) ~[?:?]
        at io.github.kr8gz.playerstatistics.database.Database$Initializer$Companion.populateTables$streamStatsFiles(Database.kt:73) ~[playerstatistics-0.1.1+1.20.jar:?]
        at io.github.kr8gz.playerstatistics.database.Database$Initializer$Companion.populateTables(Database.kt:75) ~[playerstatistics-0.1.1+1.20.jar:?]
        at io.github.kr8gz.playerstatistics.database.Database$Initializer$Companion.access$populateTables(Database.kt:48) ~[playerstatistics-0.1.1+1.20.jar:?]
        at io.github.kr8gz.playerstatistics.database.Database$Initializer$Companion$run$2.invokeSuspend(Database.kt:63) ~[playerstatistics-0.1.1+1.20.jar:?]
        at io.github.kr8gz.playerstatistics.database.Database$Initializer$Companion$run$2.invoke(Database.kt) ~[playerstatistics-0.1.1+1.20.jar:?]
        at io.github.kr8gz.playerstatistics.database.Database$Initializer$Companion$run$2.invoke(Database.kt) ~[playerstatistics-0.1.1+1.20.jar:?]
        at io.github.kr8gz.playerstatistics.database.Database$transaction$1.invokeSuspend(Database.kt:32) ~[playerstatistics-0.1.1+1.20.jar:?]
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) ~[org_jetbrains_kotlin_kotlin-stdlib-1.9.24-16069ac40415d960.jar:?]
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104) ~[org_jetbrains_kotlinx_kotlinx-coe-jvm-1.8.0-28ce486c5cdc0b22.jar:?]
        at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:111) ~[org_jetbrains_kotlinx_kotlinx-coe-jvm-1.8.0-28ce486c5cdc0b22.jar:?]
        at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:99) ~[org_jetbrains_kotlinx_kotlinx-coe-jvm-1.8.0-28ce486c5cdc0b22.jar:?]
        at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:585) ~[org_jetbrains_kotlinx_kotlinx-coe-jvm-1.8.0-28ce486c5cdc0b22.jar:?]
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:802) ~[org_jetbrains_kotlinx_kotlinx-coe-jvm-1.8.0-28ce486c5cdc0b22.jar:?]
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:706) ~[org_jetbrains_kotlinx_kotlinx-coe-jvm-1.8.0-28ce486c5cdc0b22.jar:?]
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:693) ~[org_jetbrains_kotlinx_kotlinx-coe-jvm-1.8.0-28ce486c5cdc0b22.jar:?]
        Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException
[13:52:54] [DefaultDispatcher-worker-1/INFO]: Finished database initialization

Other than that, seems to be working fine server-side.

kr8gz commented 2 months ago

Oh yeah that's an embarrassing oversight, good catch

kr8gz commented 2 months ago

Hello @i240c, I have released a version for 1.21: https://modrinth.com/mod/playerstatistics/version/0.1.2+1.21

When starting a fresh server without any stats, mod fails

@MJRamon this issue has been fixed with the new release as well.

Please test the new versions – if there are no problems, this issue can be closed :)