search

kr8s-org / kr8s

A batteries-included Python client library for Kubernetes that feels familiar for folks who already know how to use kubectl
https://kr8s.org
BSD 3-Clause "New" or "Revised" License
799 stars 43 forks source link

Fix loadBalancer attribute name #496

Closed jacobtomlinson closed 1 week ago

jacobtomlinson commented 1 week ago

It was highlighted in https://github.com/dask/dask-kubernetes/issues/906 that kr8s is accessing the Service loadBalancer attribute via the load_balancer key. This is likely a bug left over from some previous experiements with automatically converting camel case keys to snake case keys.

This PR switches the syntax to use camel case, which means it should now work as expected. I also opened #495 to track adding full support for camel => snake conversion.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.19%. Comparing base (87063fc) to head (8e74477). Report is 116 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #496 +/- ## ========================================== + Coverage 94.61% 95.19% +0.57% ========================================== Files 29 30 +1 Lines 3141 3973 +832 ========================================== + Hits 2972 3782 +810 - Misses 169 191 +22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.