search

kra-mo / cartridges

A GTK4 + Libadwaita game launcher
GNU General Public License v3.0
571 stars 29 forks source link

Steam games just open the Steam app because the Steam native packages do not support xdg-open #215

Open Kaympe20 opened 7 months ago

Kaympe20 commented 7 months ago

Describe the bug Steam native packages do not work with xdg-open, causing the Steam app to be opened instead of launching a game. This can be fixed by editing the executable path and replacing "xdg-open" with "steam".

Expected behavior When playing a game from steam, the game should open or at least open the the Steam launching game screen.

Actual behavior When playing a game from Steam, the Steam app is opened with no game being launched.

System (please complete the following information):

Additional context The problem can be resolved by manually editing the executable path and replacing "xdg-open" with "steam".

kra-mo commented 7 months ago

Are you sure that the issue is a lack of support for xdg-open? If Steam still opens and the game just doesn't launch, that seems like a Steam bug.

Kaympe20 commented 7 months ago

@kra-mo Even so, it would make sense to make it work as expected by replacing "xdg-open" with "steam" in the executable path of Steam games.

kra-mo commented 7 months ago

This is exactly why I hate proprietary software. Steam's URL handler broke multiple times in the past and the correct solution here would be taking the issue upstream. Unfortunately, that's not possible and I'm not going to push a hotfix and then revert it for someone else's software every time it breaks.

Using steam would work for some, but break things for others, like those that installed Steam manually and don't have it in their $PATH.

So I'm going to leave this issue open but mark it as invalid as this is not Cartridges' responsibility and since Steam is proprietary, inactionable.