search

kra-mo / cartridges

A GTK4 + Libadwaita game launcher
GNU General Public License v3.0
653 stars 35 forks source link

Importer doesn't import specific game #227

Closed RozeFound closed 9 months ago

RozeFound commented 9 months ago

Describe the bug When trying to import games, it imports everything correctly except one game, this being Dishonored RHCP. Logs say's it's already there but it isn't

To Reproduce Steps to reproduce the behavior:

  1. Buy and install Dishonored RHCP through steam
  2. Click plus icon
  3. Click "Import"
  4. See no errors
  5. See no game

Expected behavior All games imported correctly

Screenshots image

Logs https://pastebin.com/vqacVKdj

System (please complete the following information):

It's not hidden, it simply not there.

kra-mo commented 9 months ago

I am going to assume it is blacklisted because it is not actually listed as a regular game on Steam.

Can you tell me whether in ~/.var/app/hu.kramo.Cartrdiges/data/cartrdiges/games/steam_217980.json, blacklisted is set to true?

kra-mo commented 9 months ago

Can you tell me what "RHCP" means btw? Because the Steam API just returns "Dishonored" and I can't find any info on it.

RozeFound commented 9 months ago

Looks like you're right "blacklisted": true is in this file

Can you tell me what "RHCP" means btw?

I'm not sure myself tbh, I assume that's regional. On reddit and steam discussion people say it's "Russian, Czech, Hungarian, Polish"

kra-mo commented 9 months ago

That is weird because the game is actually listed as a game so I wonder if this was the result of a temporary failure. If you remove the JSON file representing the game and import again, will it still import as blacklisted?

RozeFound commented 9 months ago

Yes it still imported as blacklisted. On another note, wallpaper engine is not a game and somehow imported like one.

kra-mo commented 9 months ago

Well, that one is listed as a game so it's not Cartridges' fault.

https://store.steampowered.com/api/appdetails?appids=431960

I'll see what the issue could be with Dishonored when I get home and can test it.

kra-mo commented 9 months ago

This is really weird, it works fine for me with the game. Can you please send me your manifest from the steamapps subdirectory of your Steam data dir? It should be appmanifest_217980.acf

RozeFound commented 9 months ago

Yeah sure, here's its content https://pastebin.com/ZjpfNbnD GitHub doesn't allow to upload it directly here.

kra-mo commented 9 months ago

Nope, I cannot reproduce it even with the exact same manifest. I have zero idea how this could happen.

My guess would be a temporary API failure and cache shenanigans making it still return false. Just in case, can you check if success equals true for this page in your browser on the same device?

https://store.steampowered.com/api/appdetails?appids=217980

RozeFound commented 9 months ago

Nope, it returns "success": false

Oh. That might be the reason

image

For the record, I bought it long before it became unavailable