search

kra-mo / cartridges

A GTK4 + Libadwaita game launcher
GNU General Public License v3.0
661 stars 35 forks source link

Unable to add new cover art #292

Closed Raindrac closed 1 month ago

Raindrac commented 1 month ago

Describe the bug Starting with version 2.10.0 on Gnome, it no longer seems possible to add cover art. I've tried adding jpegs, pngs, and more; none of them are accepted.

It works as recently as version 2.9.3, something I confirmed by downgrading the flatpak so that I could add cover art again. Hopefully that'll help narrow down what caused the regression.

To Reproduce Steps to reproduce the behavior:

  1. Add a new game, or edit an existing game
  2. Click on the New Cover button
  3. Attempt to add cover art using the file picker
  4. After leaving the file picker, the cover art doesn't change

Logs

01:47 - DEBUG: Python version: 3.12.6 (main, Nov 10 2011, 15:00:00) [GCC 14.2.0]
01:47 - DEBUG: Flatpak version: Flatpak 1.15.10
01:47 - DEBUG: Platform: Linux-6.10.7-200.fc40.x86_64-x86_64-with-glibc2.40
01:47 - DEBUG:  System: Linux
01:47 - DEBUG:  Node: carracosta
01:47 - DEBUG:  Release: 6.10.7-200.fc40.x86_64
01:47 - DEBUG:  Version: #1 SMP PREEMPT_DYNAMIC Fri Aug 30 00:08:59 UTC 2024
01:47 - DEBUG:  Machine: x86_64
01:47 - DEBUG:  Processor: 
01:47 - DEBUG: ─────────────────────────────────────
01:47 - DEBUG: New store game Steam (desktop_com.valvesoftware.Steam)
01:47 - DEBUG: DisplayManager done for desktop_com.valvesoftware.Steam
01:47 - DEBUG: New store game Proton Experimental (steam_1493710)
01:47 - DEBUG: DisplayManager done for steam_1493710

Beyond this point, the logs only contain Cartridges reporting "New store name x" and "Display manager done for x" for each respective game in my library, so I've omitted the rest of it. Doesn't appear to be much useful here beyond some system specs.

System

Additional context Fedora is currently running on Gnome 46, and so it's using the old file picker rather than using the new Nautilus-based file picker. Possibly relevant?

AstroSquared commented 1 month ago

I can confirm this bug, although I found an error on the logs (logs from flatpak run and not the app's debug logs):

Traceback (most recent call last):
  File "/app/lib/python3.12/site-packages/cartridges/details_dialog.py", line 321, in set_cover
    self.toggle_loading()
  File "/app/lib/python3.12/site-packages/cartridges/details_dialog.py", line 288, in toggle_loading
    self.spinner.set_visible(not self.spinner.get_spinning())
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Spinner' object has no attribute 'get_spinning'

I can confirm this only exists on the latest version (2.10.0) as this issue is gone upon downgrading (2.9.3). I'm also running Gnome 46, but on NixOS and using Flatpak to install.