kra-mo / cartridges

A GTK4 + Libadwaita game launcher
GNU General Public License v3.0
640 stars 33 forks source link

Weird artifact appears in darker backgrounds #74

Closed Mars7x closed 1 year ago

Mars7x commented 1 year ago

Describe the bug If you game uses a darker cover art, then the background will have this weird artifact at the bottom of it.

To Reproduce Steps to reproduce the behavior:

  1. Set the cover art to anything that has black/dark colours at the bottom of it.

Expected behavior Be consistent with the rest of the background.

Screenshots Screenshot from 2023-04-24 08-14-24

Screenshot from 2023-04-24 08-17-06

Screenshot from 2023-04-24 08-17-33

kra-mo commented 1 year ago

This is not really an artifact. The current way of blurring the game covers for the background is simply downscaling it to 2x3 pixels and then upscaling it to fit the app. This doesn't really work for backgrounds with a lot of color variation so I will need to find a better algorithm.

lorhof1 commented 1 year ago

I tested some things and changing it to 3x4 seems to reduce the issues a bit without impacting other covers. Before: Bildschirmfoto vom 2023-05-02 11-15-50 After: Bildschirmfoto vom 2023-05-02 11-15-17 Cover image used: Unbenannt

kra-mo commented 1 year ago

I will probably just apply a blur later on as this still looks relatively weird. I have already implemented a way of doing it, I just need to optimize it.