search

kra-mo / sly

Friendly image editor
https://sly.kramo.page
GNU General Public License v3.0
112 stars 2 forks source link

Provide light style #23

Closed bremensaki closed 1 month ago

bremensaki commented 1 month ago

Installed via Flathub, the application is starting up in dark mode despite my GNOME system theme being set to light. I can't see any control to change this, but I may be missing it as I cannot focus properly on the UI elements.

This is an accessibility issue, the system theme should be used by default.

kra-mo commented 1 month ago

The system theme will not be used by default, many media-related applications are dark by default for a reason, to let the user focus on the content. However, when an explicit light style is set, following that would be good.

bremensaki commented 1 month ago

If there's a reason to not follow the system theme in the absence of a defined preference, it's not a good one. Some of us literally cannot read text in dark themes, making navigating the UI very difficult, if not impossible.

I have my system theme set to light because I need it that way to be able to use the computer. Have a separate preference that overrides the system one for an application by all means, but it needs to default to the global preference or the settings themselves can be inaccessible.

kra-mo commented 1 month ago

The default global preference ('system') is not 'prefer light' though. It is 'no preference'. If you set your system to prefer light, it should follow it, otherwise, the application can decide. This is not a matter of debate, it's just how the specification is written.

https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Settings.html